Saturday, December 4, 2021

Dev Meeting Transcript (December 3, 2021)

[4:00 PM] kinkajou (SegWit Clique): Channel open.

[4:00 PM] LSJI07 - BWS: HI

[4:00 PM] LSJI07 - BWS: Hi (speaking normally...)

[4:00 PM] kralverde πŸ‡ΊπŸ‡Έ {CULT OF JOE}: πŸ‘‹

[4:00 PM] fdov: Hello.

[4:00 PM] Tron: Hi

[4:01 PM] LSJI07 - BWS: i put together a list of items to discuss. not sure if people want to add things before we start in earnest.

[4:01 PM] LSJI07 - BWS: 1. Release date. When anticipated for P2SH and latest updates to GUI?

  1. Testing P2SH and release v4.7test3 by fdov needs more testers specifically arm/osx/arch.

  2. Testing P2SH I found that using the console is required. Propose adding GUI for P2SH multisig address creation (say 1 to 15 addresses only) and spending process to obtain partial hash to send to cosigners.

  3. Ideally also need a demo or explanation (console or other) for multisig creation and making a transaction for the various assets. Be useful to those wanting to test and try the software.

#5 https://www.ravencoin.timeline.ovh/rvn-tokenisation-made-easy-for-any-business/

[4:02 PM] fdov: I don't think the "funding external projects part" has anything to do with development. Do that in a foundation meeting please.

[4:05 PM] Tron: Gut feel is that we don't start counting blocks until after the halvening.

[4:05 PM] Tron: Downloads can be available before then.

[4:07 PM] fdov: I was hoping to gather troops and make a release before years end. I have a lot of work until the holidays.

[4:07 PM] fdov: .. and it does not get much better once the holiday is over, for me anyway.

[4:08 PM] LSJI07 - BWS: So counting starts in beginning February essentially with releases hopefully ready by the end of december. Thats the plan at the moment anyway.

[4:08 PM] Tron: Sounds good.

[4:09 PM] kralverde πŸ‡ΊπŸ‡Έ {CULT OF JOE}: Yeah i can be a lot more active once the holidays come

[4:10 PM] LSJI07 - BWS: Number 1 is covered imo. Anyone wandering in late please feel free to comment!

[4:11 PM] LSJI07 - BWS: or later than me...im either 12 hours early or 12 hours late.... no half measures!

[4:11 PM] LSJI07 - BWS: 2. Testing P2SH and release v4.7test3 by fdov needs more testers specifically arm/osx/arch.

[4:12 PM] fdov: Great progress in the testing the last few days. Got some ✅ on my list.

[4:12 PM] kralverde πŸ‡ΊπŸ‡Έ {CULT OF JOE}: I can build on my pi, i think that would cover armv

[4:12 PM] kralverde πŸ‡ΊπŸ‡Έ {CULT OF JOE}: 7?

[4:12 PM] LSJI07 - BWS: This and #4 are kinda linked imo.

[4:12 PM] LSJI07 - BWS: 4. Ideally also need a demo or explanation (console or other) for multisig creation and making a transaction for the various assets. Be useful to those wanting to test and try the software.

[4:12 PM] fdov: kralverde πŸ‡ΊπŸ‡Έ {CULT OF JOE} you don't have to build, you can just test the binaries. (or build if you want).

[4:12 PM] kralverde πŸ‡ΊπŸ‡Έ {CULT OF JOE}: Ill go the whole 9 yards

[4:13 PM] fdov: Would be nice if you also tested the binaries I made, check that my build-environment actually works.

[4:13 PM] RAVENCOIN.TIMELINE.OVH: #5 https://www.ravencoin.timeline.ovh/rvn-tokenisation-made-easy-for-any-business/

[4:13 PM] LSJI07 - BWS: i have something for console and making the P2SH addresses. spending from that address I need help with though!

[4:14 PM] kralverde πŸ‡ΊπŸ‡Έ {CULT OF JOE}: I wanna try and stick in torv3 support before release too

[4:14 PM] Hans_Schmidt: It would be good if someone (in addition to the tests I did) could test asset atomic transfers using P2SH

[4:14 PM] kralverde πŸ‡ΊπŸ‡Έ {CULT OF JOE}: Yessir

[4:14 PM] kralverde πŸ‡ΊπŸ‡Έ {CULT OF JOE}: Could you link your run downs regarding that again?

[4:15 PM] fdov: We could try, but I suggest releasing without torv3 first. THen make a .1 with torv3 pretty quickly after.

[4:17 PM] LSJI07 - BWS: This is what i did for making a multisig address and documented etc.

Creating a multi-signature address with Ravencoin QT 4.7.

A 2-of-3 multisig address can be created by following these steps:

  1. Gather (or generate) 3 ravencoin addresses, on whichever machines will be participating, using getnewaddress or getaccountaddress RPC commands (or copy and paste from the GUI).

  2. Get their public keys using the validateaddress RPC command for each address or using getaddressinfo and copying the pubkey value.

  3. Then create a 2-of-3 multisig address using addmultisigaddress; e.g.,

ravend addmultisigaddress 2 '["044322868cb17d64dcc22185ae2d4493111d73244c3668f8ac79ecc79c0ba8d30a6756d0fa20157 709af3281cc721c7f53321a8cabda29b77900b7e4fe0174b114","..second pubkey..","..third pubkey.."]'

  1. addmultisigaddress returns the multi-signature address. Be a little careful, the public keys are raw hexadecimal and don't contain checksums like ravencoin addresses do. You can then send funds into that 2-of-3 transaction using the normal sendtoaddress/sendmany RPC commands, or the GUI (or anything that's been updated to recognize multisig addresses).

[4:17 PM] fdov: I pretty much want the release to be close to test3 - without much code change. - If we make it and feel good about it, I can change my mind.

[4:18 PM] Hans_Schmidt: Every contribution is welcome of course. But rushing in a tor update seems risky to me in light of all the other things already in there which could use more testing.

[4:18 PM] kralverde πŸ‡ΊπŸ‡Έ {CULT OF JOE}: Ill work on a pr but leave it on the backburner

[4:19 PM] LSJI07 - BWS: I need help with how a user can send from a multisig on RVN using assets. rawtransactions are fun!

[4:19 PM] Tron: If the Tor update doesn't impact consensus, it can be added later and without a hard fork.

[4:19 PM] kralverde πŸ‡ΊπŸ‡Έ {CULT OF JOE}: https://hans-schmidt.github.io/mastering_ravencoin/analysis/HTLC_P2SH_Cross-Chain_Atomic_Swaps_RVN-Assets_With_BTC.html @Hans_Schmidt this is still your latest work correct?

[4:20 PM] fdov: FYI: I'm working on gitian building, to be able to make deterministic builds, like bitcoin did. (they switched to guix). - PR is in the list as a draft. It builds and works, but only deterministic for OSX. I have not had the time to figure out why.

[4:20 PM] fdov: It does not.

[4:21 PM] Hans_Schmidt: Yes, for P2SH asset atomic swaps. It is tedious, but should provide an outline to follow for more testing.

[4:22 PM] kralverde πŸ‡ΊπŸ‡Έ {CULT OF JOE}: Awesome

[4:22 PM] LSJI07 - BWS: kralverde πŸ‡ΊπŸ‡Έ {CULT OF JOE}@Hans_Schmidt awesome, thanks for linking!

[4:22 PM] LSJI07 - BWS: and making!

[4:23 PM] Tron: Thank you everyone for helping on this release.

[4:27 PM] LSJI07 - BWS: Item 2 done - WE NEED MORE COMMUNITY TESTERS FOR ARM/OSX/ARCH. Please. πŸ˜‰

[4:27 PM] Tron: I can put a call out on Twitter.

[4:28 PM] fdov: I found that crying on discord helps. πŸ˜‰

[4:28 PM] LSJI07 - BWS: Item 3. Testing P2SH I found that using the console is required. Propose adding GUI for P2SH multisig address creation (say 1 to 15 addresses only) and spending process to obtain partial hash to send to cosigners. Any objections to this or ideas to help?

[4:29 PM] LSJI07 - BWS: this may help if we consider adding hardware wallet support later...

[4:30 PM] LSJI07 - BWS: something simple like https://coinb.in/#newMultiSig for creating a p2sh address in wallet.

[4:31 PM] kralverde πŸ‡ΊπŸ‡Έ {CULT OF JOE}: That might be another thing to put in 7.1

[4:31 PM] kralverde πŸ‡ΊπŸ‡Έ {CULT OF JOE}: Though if its just a gui, it should be trivial…

[4:32 PM] kralverde πŸ‡ΊπŸ‡Έ {CULT OF JOE}: Ill take a look over the holidays

[4:33 PM] LSJI07 - BWS: its not concensus related after the p2sh fork is done. Imo it would help people using the wallet and personally use a multisig in the QT wallet .

[4:33 PM] LSJI07 - BWS: I'll make an issue and see if anyone wants the challenge.

[4:34 PM] fdov: Should not be hard.

[4:34 PM] kralverde πŸ‡ΊπŸ‡Έ {CULT OF JOE}: I’ll just copy whatever electrum does gui wise πŸ˜‰

[4:35 PM] Hans_Schmidt: Testing on each OS is necessary to verify binary generation and dependencies. But I have never seen an alternate-OS functionality problem which risks the chain. Would you agree with that?

[4:36 PM] LSJI07 - BWS: Careful. I looked quickly and to me it looked like they created a seperate seed for multisig addresses. I liked the gui though.

[4:36 PM] fdov: No, It is just to make sure binaries we release actually work.

[4:37 PM] LSJI07 - BWS: I have seen more user errors and not specifically OS issues....just saying....

[4:37 PM] fdov: OSX is usually the worst.

[4:37 PM] LSJI07 - BWS: Item 3 done. I'll create an issue.

[4:38 PM] fdov: I have to take a ~20min break in 10 minutes.

[4:38 PM] LSJI07 - BWS: Item 4 was covered earlier.

[4:38 PM] LSJI07 - BWS: Item #5 https://www.ravencoin.timeline.ovh/rvn-tokenisation-made-easy-for-any-business/

[4:39 PM] LSJI07 - BWS: i have not looked at this yet.

[4:39 PM] Hans_Schmidt: Not surprisingly, stuff worst best on the platforms which the devs mostly use.

[4:42 PM] LSJI07 - BWS: This looks like a request list for layer 2 development. Somethings mentioned can only be done by a business. Like sign ins and banking links etc etc.

[4:44 PM] fdov: I like the idea. I guess it's much like Mango isn't it?

[4:45 PM] LSJI07 - BWS: looks like a skinnable mango but the banking connections centralised around a "onramp/offramp" for want of better words.

[4:46 PM] fdov: But the request is someone makes it and share it for free to anyone on github.

[4:47 PM] Tron: Mango can be whitelabeled, but it isn't free.

[4:47 PM] mattan138: If QT essentially looked like this they'd be set for the most part.

[4:50 PM] fdov: Personally I want to focus on core+qt. And I would prefer if the foundation directs most of its attention to the core development. The core is Ravencoin. If that somehow breaks, all L2s die with it.

[4:50 PM] kinkajou (SegWit Clique): Is there a reason we don't include an IPFS viewer in the QT just for the asset creation part? to verify that you have the correct hash if nothing else?

[4:50 PM] kinkajou (SegWit Clique): so when you check to see if the asset name is available youre also able to verify your ipfs hash

[4:52 PM] fdov: We can make a button to open it in the default browser with the configured web-viewer. But including a viewer into core, is not something I (and i think Hans) want at all. It will introduce all sorts of potential security issues.

[4:52 PM] Blockchain John: Is there any company being built on Ravencoin to help secure and protect Intellectual Property?

[4:52 PM] Blockchain John: Question: is P2SH estimated to forked into the chain in 2023? Here's the code that makes me think that.....

LINE 165 consensus.vDeployments[Consensus::DEPLOYMENT_P2SH_ASSETS].nStartTime = 1682956800; // UTC: Mon Mai 01 2023 18:00:00

https://github.com/fdoving/Ravencoin/commit/04eba4fd84eddea5268a2d213d92e9e4a90e7117#diff-ff53e63501a5e89fd650b378c9708274df8ad5d38fcffa6c64be417c4d438b6dL165

[4:53 PM] fdov: No. This is just set to something that will never happen, for it not to activate by accident.

[4:53 PM] LSJI07 - BWS: Blockchain John it was likely just moved far into the future... while testing other features.

[4:53 PM] Hans_Schmidt: Viewers are a main source of security vulnerability for many applications. An ability to chose an external viewer after you click a box verifying that you understand the risks would be more acceptalbe.

[4:53 PM] Blockchain John: Ahh ok. Perfect.

[4:54 PM] kinkajou (SegWit Clique): Right, I agree with that. A button would be nice so that you can view the content externally during creation much the same way that you can view it from your asset balance.

[4:54 PM] kralverde πŸ‡ΊπŸ‡Έ {CULT OF JOE}: yes, electrum has their own mnemonic system

[4:54 PM] kralverde πŸ‡ΊπŸ‡Έ {CULT OF JOE}: some may say its better than bip39, but...

[4:55 PM] kralverde πŸ‡ΊπŸ‡Έ {CULT OF JOE}: the rest is the same

[4:55 PM] Blockchain John: How can I become a Ravencoin IPFS Node host? From what I understand there is a script not that scans Assets and NFTs minted on RAVENCOIN. and the IPFS is pinned automatically by s community of volunteers

[4:55 PM] LSJI07 - BWS: raise an issue and if a dev wants to help ravencoin they can add it.

[4:57 PM] Blockchain John: There's been a concern from the community that some pools are getting to large and causing issues in the network. There's been a recent delay of 8 minutes with no blocks being discovered. Which was said to be due to mining pool manipulating the network. We definitely need more pools if this is the problem.

[4:57 PM] Tron: https://github.com/RavenProject/Ravencoin/blob/master/assets/tools/ipfs_pinner.py

[4:57 PM] Blockchain John: Thank you

[4:58 PM] LSJI07 - BWS: has anyone got it to work? not being cheeky. I have failed several times on windows and linux.

[5:00 PM] LSJI07 - BWS: tried qt and ravend. ipfs node fails to connect.

[5:00 PM] Blockchain John: Ruh roh.

[5:01 PM] LSJI07 - BWS: zmq running. with assetindex=1 and txindex=1

[5:01 PM] LSJI07 - BWS: and server=1

[5:01 PM] kralverde πŸ‡ΊπŸ‡Έ {CULT OF JOE}: and a ipfs node running ;)?

[5:01 PM] LSJI07 - BWS: lol

[5:01 PM] LSJI07 - BWS: yes.

[5:02 PM] kralverde πŸ‡ΊπŸ‡Έ {CULT OF JOE}: it seems like it would work to me, what was the error you had?

[5:02 PM] Hans_Schmidt: We did already do PR#901 Configurable IPFS Browser url, which defaults to https://ipfs.io/ipfs/

[5:02 PM] Tron: RPC user and pwd?

[5:03 PM] LSJI07 - BWS: yes. i got annoyed and set it to default even to try it. i use rpc for mining on testnet and that works fine.

[5:03 PM] Blockchain John: Last question: I'm looking for the option to pull transactions from my address. I'm not about to take QT with me as it's on my computer. But I would like to know what transaction as occuring on my address. How can I pull an API

[5:04 PM] kralverde πŸ‡ΊπŸ‡Έ {CULT OF JOE}: that would be an open rpc from the node

[5:04 PM] kralverde πŸ‡ΊπŸ‡Έ {CULT OF JOE}: or 3rd parties like rvn.cryptoscope.io

[5:04 PM] Blockchain John: Thanks

[5:06 PM] LSJI07 - BWS: some of the ipfsapi stuff is deprecated in the script. if someone has it working just say so, and ill be quiet and re figure my stuff out. thumbs up if you have it working please.

[5:09 PM] LSJI07 - BWS: I have to get off but appreciate all of your efforts in this community! Thank you! πŸ‘Ό

[5:09 PM] fdov: We can extend that to a button in the Create Assets-view, the button can be activated around here: https://github.com/RavenProject/Ravencoin/blob/392b2becb286de0f5fd61ac84a5f2561d2460527/src/qt/createassetdialog.cpp#L515

[5:10 PM] fdov: Once a good hash is found, the button activates. On button presse, we ask the user with a popup if she wants to open this url in the browser.

[5:12 PM] Tron: I like it. It would be nice to have a check box or option to "Don't ask me again.". Basically a one time warning.

[5:12 PM] fdov: More work. But I agree.

[5:13 PM] kinkajou (SegWit Clique): Love it. So long as it doesn't prevent users from minting in the event no one has pinned the file.

[5:14 PM] fdov: It will basically just open the browser at a url.

[5:14 PM] kralverde πŸ‡ΊπŸ‡Έ {CULT OF JOE}: the issue with that is ipfs propogation time

[5:14 PM] kralverde πŸ‡ΊπŸ‡Έ {CULT OF JOE}: nlogn time and all that

[5:14 PM] kralverde πŸ‡ΊπŸ‡Έ {CULT OF JOE}: there should be an override for the button enabling

[5:15 PM] fdov: That will be the users problem.

[5:15 PM] kralverde πŸ‡ΊπŸ‡Έ {CULT OF JOE}: lol

[5:15 PM] kralverde πŸ‡ΊπŸ‡Έ {CULT OF JOE}: okay

[5:15 PM] fdov: Don't you think?

[5:15 PM] kralverde πŸ‡ΊπŸ‡Έ {CULT OF JOE}: your saying the button will only activate if a public gateway gets the hash right?

[5:16 PM] kralverde πŸ‡ΊπŸ‡Έ {CULT OF JOE}: actually

[5:16 PM] kralverde πŸ‡ΊπŸ‡Έ {CULT OF JOE}: yeah user problem

[5:16 PM] fdov: No, it checks for Qm and 46 chars.

[5:16 PM] kralverde πŸ‡ΊπŸ‡Έ {CULT OF JOE}: okay i see

[5:16 PM] kralverde πŸ‡ΊπŸ‡Έ {CULT OF JOE}: i was unsure of what "good hash" meant

[5:16 PM] kralverde πŸ‡ΊπŸ‡Έ {CULT OF JOE}: shoulda asked

[5:17 PM] Tron: We don't want the client checking for existence against server. Just letting them click to open the browser (with a warning).

[5:17 PM] fdov: I was planning on using the sanity-check already used to activate the Create Asset button.

[5:19 PM] fdov: But I guess this is a level of detail out of the scope of this meeting. Should continue indevelopment or ravenqt-sig-working

[5:21 PM] Hans_Schmidt: I think this makes sense as an extension to what we already did in PR#901. And browsers make good viewers because they have already evolved into security sandboxes.

[5:27 PM] Nonprophete: Didn't see it answered, but may have missed it. What is the ETA for the P2SH hardfork?

[5:29 PM] fdov: Nonprophete Hope to release before years end, start counting after halving, early feb, active around march if pools upgrade.

[5:30 PM] fdov: LSJI07 - BWS Are we finished?

[5:32 PM] BadGuyTy: I came late but didn't see it mentioned did you get your help with raw transactions LSJI07 - BWS ?

[5:33 PM] BadGuyTy: I would also like an ETA for the hardfork. I have all but decided that is going to be a requirement for squawker usability.

[5:36 PM] BadGuyTy: I'm being dumb... I'll just move to test net where it is already active with the disclaimer that nothing we do there will be carried over...

[5:38 PM] kinkajou (SegWit Clique): Just answered, expected in Feburary-March but ultimately depends on the pools/miners

[5:39 PM] kinkajou (SegWit Clique): If there are no other questions/issues for the core devs I will close the channel shortly.


No comments:

Post a Comment